D19334: redo service menu ruby helpers from ground up more or less

[Harald Sitter]

sitter updated this revision to Diff 52648.
sitter added a comment.


  don't use `strip!`. it comes back nil when nothing was stripped which is not useful behavior in the way it is used (i.e. if nothing needed stripping we really don't care)

REPOSITORY
  R318 Dolphin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19334?vs=52604&id=52648

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19334

AFFECTED FILES
  src/settings/services/servicemenudeinstallation
  src/settings/services/servicemenuinstallation
  src/settings/services/test/service_menu_deinstallation_test.rb
  src/settings/services/test/service_menu_installation_test.rb
  src/settings/services/test/test_helper.rb
  src/settings/services/test/test_run.rb
  src/tests/CMakeLists.txt

To: sitter, #dolphin
Cc: kfm-devel, alexde, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190226/10cfea6e/attachment.htm>