D19201: New tab placed after current tab when middle-clicking

[David Hallas]

hallas added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in dolphintabwidget.h:33
> The clash protection is a good argument, but then it's an unrelated change that should go in another commit (and there are many other old-style enums in dolphin which should be ported).
> 
> I don't think we have guidelines about enums in KDE, but using `enum class` for new code makes sense of course.

I have reverted this part of the change, so keeping the enum as an enum and as a type within DolphinTabWidget and then include it in the headers that now require it - hope that is ok :)

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D19201

To: hallas, #dolphin, ngraham, elvisangelaccio
Cc: kfm-devel, alexde, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190225/b199b509/attachment.htm>