D19190: Improve scroll wheel speed by basing it on label height, not icon height

[Nathaniel Graham]

ngraham added a comment.


  In D19190#418914 <https://phabricator.kde.org/D19190#418914>, @elvisangelaccio wrote:
  
  > > This patch makes the size of the scroll step fixed, using the height of 2.5 text labels + their padding, which is what KDirOperator does.
  >
  > Are you sure? It seems to me that the file dialog respects the standard 3-lines/items scroll step, while this patch breaks it.
  
  
  Ah, but what constitutes an item? The bug is that the icon's height counts for the the purpose of determining the height of one line, which makes the scroll speed variable for views with different icon layouts and height, and very uncomfortable when icons are large. It's really annoying.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D19190

To: ngraham, #dolphin, elvisangelaccio
Cc: anthonyfieroni, kfm-devel, alexde, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190224/d54818bb/attachment.htm>