D19243: Allow the FileMetaDataConfigWidget to emit a loadedMetadata signal when its metadata has been loaded, and adjust its size based on its content

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> filemetadataconfigwidget.cpp:205
> +    const int lineHeight = metrics.height();
> +    QSize size = QSize(20, d->m_metaDataList->count() * lineHeight);
> +    return size;

This feels like papering over a different issue - the `QListWidget` should provide an appropriate sizeHint, as it knows its items, and each list item should provide a correct size hint.

> elvisangelaccio wrote in filemetadataconfigwidget.h:65
> I'd call it `loadingFinished()` to match the `FileMetaDataProvider::loadingFinished` signal.

The question is - who is going to receive this signal?

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D19243

To: meven, #dolphin, #baloo, ngraham
Cc: bruns, elvisangelaccio, ngraham, #baloo, domson, ashaposhnikov, astippich, spoorun, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190223/11e81783/attachment.htm>