D19241: Show the FileMetaDataConfigurationDialog dialog only after its widget has emmitted metadataLoaded signal

[Nathaniel Graham]

ngraham added a reviewer: Dolphin.
ngraham added a comment.


  You can run the tests with `ctest` while in the build directory (or the source directory, if you did an in-source build (boo!)).
  
  The general approach seems reasonable, but just complicated by the fact that the dialog's content is provided by something in `baloo-widgets`. Dolphin is the only client of that, so in the long term I would support moving it back into Dolphin.
  
  Anyway, that's up to the #dolphin <https://phabricator.kde.org/tag/dolphin/> folks. :) Thanks for the patch!

INLINE COMMENTS

> filemetadataconfigurationdialog.cpp:37
>      m_configWidget(nullptr)
> -
>  {

Unrelated change.

> filemetadataconfigurationdialog.h:73
> +private slots:
> +    void slotShowDiablog();
> +

Typo. :)

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D19241

To: meven, #dolphin
Cc: ngraham, kfm-devel, alexde, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190223/d7ecb3ca/attachment.htm>