D19243: Allow the FileMetaDataConfigWidget to emit a loadedMetadata signal when its metadata has been loaded, and adjust its size based on its content

[Nathaniel Graham]

ngraham added reviewers: Dolphin, Baloo.
ngraham requested changes to this revision.
ngraham added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> filemetadataconfigwidget.cpp:203
> +    // use 28 px as default line height
> +    QSize size = QSize(20, d->m_metaDataList->count() * 28);
> +    return size;

Better to read the actual text metrics rather than assuming a height. Something like this:

  const QFontmetrics metrics(d->m_metaDataList->font())
  const int lineHeight = metrics.height()

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D19243

To: meven, #dolphin, #baloo, ngraham
Cc: ngraham, #baloo, domson, ashaposhnikov, astippich, spoorun, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190223/26ad7153/attachment.htm>