D19111: Have ShareFileItemAction provide an output or an error if they are provided

Nicolas Fella noreply at phabricator.kde.org
Thu Feb 21 16:55:43 GMT 2019


nicolasfella accepted this revision.
nicolasfella added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> CMakeLists.txt:3
> +find_package(KF5Notifications COMPONENTS)
> +if (NOT KF5KIO_FOUND OR NOT KF5Notifications_FOUND)
> +    return()

Maybe move the check to the parent CMakeLists.txt and include fileitemactionplugin conditionally?

REPOSITORY
  R495 Purpose Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19111

To: apol, #dolphin, #frameworks, nicolasfella
Cc: ngraham, kde-frameworks-devel, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190221/5fe87e9d/attachment.htm>


More information about the kfm-devel mailing list