D19112: Fix crash during shutdown

[David Hallas]

hallas created this revision.
hallas added reviewers: Dolphin, elvisangelaccio, ngraham.
hallas added a project: Dolphin.
hallas requested review of this revision.

REVISION SUMMARY
  Fix crash during shutdown. The root cause is that when Dolphin in stopped as
  part of an activity, the KItemListViewAccessible destructor is called after
  QApplication::exec has returned causing Qt to already having cleaned up the
  QAccessibleInterface instances kept in KItemListViewAccessible. Instead of
  storing the pointers to QAccessibleInterface we store the QAccessible::Id so
  that we can use the QAccessible::deleteAccessibleInterface function for
  deleting the instances.
  
  BUG: 402784

TEST PLAN
  I wasn't able to reproduce the crash in the first place, but I have just
  opened and closed Dolphin a few times and verified the the QAccessibleInterface
  instances are correctly cleaned up.

REPOSITORY
  R318 Dolphin

BRANCH
  Applications/18.12

REVISION DETAIL
  https://phabricator.kde.org/D19112

AFFECTED FILES
  src/kitemviews/kitemlistviewaccessible.cpp
  src/kitemviews/kitemlistviewaccessible.h

To: hallas, #dolphin, elvisangelaccio, ngraham
Cc: kfm-devel, alexde, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190218/3ec1f32d/attachment.htm>