D18945: New tab should be placed after the current tab

[David Hallas]

hallas added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in dolphintabwidget.cpp:161-168
> How about a simpler if?
> 
>   int newTabIndex = -1;
>   if (tabPlacement == AfterCurrent) {
>       newTabIndex = currentIndex() + 1;
>   }
> 
> (we can always make it a `switch` if we add new values to the enum, which is unlikely).

Yes this is a bit simpler :)

> elvisangelaccio wrote in dolphintabwidget.h:42
> How about `AfterCurrentTab` and `AfterLastTab` ? The underscore is unusual in camelcase names.

Good point, I have changed the names

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D18945

To: hallas, #dolphin, ngraham, elvisangelaccio
Cc: elvisangelaccio, ngraham, kfm-devel, alexde, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190216/fe789a64/attachment.htm>