D18040: Add option to choose which view to close

Nathaniel Graham noreply at phabricator.kde.org
Thu Feb 14 22:56:22 GMT 2019


ngraham accepted this revision.
ngraham added a comment.


  I would move your new `setToolTip()` up one line, yeah. But just as a general principle, we strive to copy the formatting of the existing code.
  
  The behavior and UX is now perfect to me. Code generally looks sane too. @elvisangelaccio, what do you think?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D18040

To: angeloevertonjr, ngraham, #dolphin, elvisangelaccio
Cc: elvisangelaccio, cfeck, kfm-devel, alexde, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190214/9e442129/attachment.htm>


More information about the kfm-devel mailing list