D18945: New tab should be placed after the current tab

[David Hallas]

hallas marked an inline comment as done.
hallas added a comment.


  @ngraham  - do you have any comments for this from a usability point of view?

INLINE COMMENTS

> ngraham wrote in dolphintabwidget.h:112
> In general, using bools as arguments is not ideal since it's not very readable. Consider defining an Enum instead.
> 
> For further information see for example:
> 
> - http://flipcode.com/archives/Replacing_Bool_Arguments_With_Enums.shtml
> - https://codereview.stackexchange.com/questions/11300/boolean-enums-improved-clarity-or-just-overkill

Good point! I have created an enum instead.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D18945

To: hallas, #dolphin, ngraham
Cc: ngraham, kfm-devel, alexde, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190213/3f5ca335/attachment.htm>