D18838: Fix opening http links in browser

Elvis Angelaccio noreply at phabricator.kde.org
Sun Feb 10 16:57:53 GMT 2019


elvisangelaccio added a comment.


  +1 otherwise. 
  Would be nice if we manage to not keep the http link in the URL navigator, but that's probably an unrelated issue.

INLINE COMMENTS

> dolphinviewcontainer.cpp:656
>          if (url.scheme().startsWith(QLatin1String("http"))) {
> -            showMessage(i18nc("@info:status", // krazy:exclude=qmethods
> -                              "Dolphin does not support web pages, the web browser has been launched"),
> -                        Information);
> +            bool ok = false;
>  

Maybe call it `launched`?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D18838

To: broulik, #dolphin, dfaure
Cc: elvisangelaccio, ngraham, ltoscano, kfm-devel, alexde, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190210/a4fe1ed2/attachment.htm>


More information about the kfm-devel mailing list