D18838: Fix opening http links in browser

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Dolphin, dfaure.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
broulik requested review of this revision.

REVISION SUMMARY
  When trying to open an http(s) link in Dolphin, the webbrowser should be launched instead.
  The codepath didn't take into account that it can be either a service or (when prefixed by an exclamation mark) an exec path. This had it try to exec the name of a desktop file which obviously didn't work.
  The fallback to Konqueror is removed as its file viewer is just a Dolphin Part and it isn't installed by default these days anymore.

TEST PLAN
  Set Browser to chromium.desktop, entered http URL, now it worked, before it said "command chromium.desktop was not found".
  Set Browser to some console command, entered http URL, console command was executed
  Didn't find a protocol that Dolphin couldn't handle but wasn't http (where the previous Konqueror fallback would kick in, `gopher:/` perhaps? :)
  
  Browsing file systems, zip folders, camera:/ still works

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D18838

AFFECTED FILES
  src/dolphinviewcontainer.cpp

To: broulik, #dolphin, dfaure
Cc: kfm-devel, alexde, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190208/44d39597/attachment.htm>