[dolphin] [Bug 415698] New: VCS plugin functions calls redundant

[Nikolai Krasheninnikov]

https://bugs.kde.org/show_bug.cgi?id=415698

            Bug ID: 415698
           Summary: VCS plugin functions calls redundant
           Product: dolphin
           Version: unspecified
          Platform: Compiled Sources
                OS: Linux
            Status: REPORTED
          Severity: minor
          Priority: NOR
         Component: general
          Assignee: dolphin-bugs-null at kde.org
          Reporter: nkrasheninnikov at yandex.ru
                CC: kfm-devel at kde.org
  Target Milestone: ---

SUMMARY
This applies to any VCS dolphin plugin. KVersionControlPlugin base class
virtual functions get called more than actually needed.
1. KVersionControlPlugin::fileName() calls each time entering directory or
updating existing one. Sometimes it get called 3 times.
2. KVersionControlPlugin::beginRetrieval()/endRetrieval() pair get called 2
times on each directory update.
3. KVersionControlPlugin::itemVersion() for each directory entry called twice.
4. When KVersionControlPlugin::actions() got implied
KVersionControlPlugin::itemVersion() get called on current item.

STEPS TO REPRODUCE
1. Add debug output to specified functions.
2. Enter a directory under VCS.
3. Call popup VCS plugin menu by right click.

OBSERVED RESULT
Virtual functions got called several times.

EXPECTED RESULT
1. KVersionControlPlugin::fileName() should be called only once on Dolphin
execution.
2. KVersionControlPlugin::beginRetrieval()/endRetrieval() should be called once
on directory update.
3. KVersionControlPlugin::itemVersion() should be called once on directory
update.
4. Implying KVersionControlPlugin::actions() should not result in itemVersion()
call since item version updates only in beginRetrieval()/endRetrieval().

SOFTWARE/OS VERSIONS
Dolphin: 20.03.70

ADDITIONAL INFORMATION
Compiled from sources of current master

-- 
You are receiving this mail because:
You are on the CC list for the bug.