D26150: Clean-up DolphinFacetsWidget
Ismael Asensio
noreply at phabricator.kde.org
Sat Dec 21 19:01:45 GMT 2019
iasensio created this revision.
iasensio added reviewers: Dolphin, elvisangelaccio.
iasensio added a project: Dolphin.
iasensio requested review of this revision.
REVISION SUMMARY
Small refactor patch to clean-up some logic on setter and getter:
- Search terms are previously splitted and set separately, so no need for extra splitting and `foreach` loop
- Return search terms on a `QStringList` rather than join first
Depends on: D26029 <https://phabricator.kde.org/D26029>
TEST PLAN
No behavior changes
REPOSITORY
R318 Dolphin
BRANCH
facets_api
REVISION DETAIL
https://phabricator.kde.org/D26150
AFFECTED FILES
src/search/dolphinfacetswidget.cpp
src/search/dolphinfacetswidget.h
src/search/dolphinsearchbox.cpp
To: iasensio, #dolphin, elvisangelaccio
Cc: kfm-devel, pberestov, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191221/9829e2c7/attachment.htm>
More information about the kfm-devel
mailing list