D25741: Add natural sorting and case-insensitive sorting for all role-types

Christoph Feck noreply at phabricator.kde.org
Thu Dec 19 09:45:14 GMT 2019


cfeck added inline comments.

INLINE COMMENTS

> kfileitemmodel.h:512
>  
> +inline bool KFileItemModel::stringRolesTrue(RoleType roleType)
> +{

The name of the function is confusing. Maybe 'isStringRole()', 'isTextualRole()', or 'roleNeedsStringSort()' ?

REVISION DETAIL
  https://phabricator.kde.org/D25741

To: gvgeo, #dolphin, nicolasfella, meven, elvisangelaccio, ngraham
Cc: cfeck, meven, kfm-devel, pberestov, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191219/2db9f9be/attachment.htm>


More information about the kfm-devel mailing list