D25130: [dolphin/search] Search by (multiple) tags
Elvis Angelaccio
noreply at phabricator.kde.org
Sun Dec 8 18:14:39 GMT 2019
elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> dolphinfacetswidget.cpp:99
> + if (event->type() == QEvent::EnabledChange) {
> + if (this->isEnabled()) {
> + updateTagsSelector();
`this->` not needed.
> dolphinfacetswidget.cpp:262
> +
> + m_tagsSelector->setEnabled(this->isEnabled() &&
> + (!m_searchTags.isEmpty() || !m_tagsSelector->menu()->isEmpty()));
`this->` not needed
> dolphinfacetswidget.cpp:283
> +
> + for (const QString tagName : qAsConst(allTags)) {
> + QAction* action = m_tagsSelector->menu()->addAction(QIcon::fromTheme(QStringLiteral("tag")), tagName);
Missing reference usage
> dolphinfacetswidget.h:29
> class QEvent;
> +class QStringList;
> +class QToolButton;
Not needed
> dolphinfacetswidget.h:32
> +
> +class KFileItemList;
>
Not needed
> dolphinfacetswidget.h:93
> +
> + QStringList m_searchTags = {};
> + KCoreDirLister m_tagsLister;
Initialization not needed, the defautl ctor is automatically called.
REPOSITORY
R318 Dolphin
REVISION DETAIL
https://phabricator.kde.org/D25130
To: iasensio, elvisangelaccio, ngraham, #dolphin, #vdg
Cc: kfm-devel, pberestov, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191208/0a7438e3/attachment.htm>
More information about the kfm-devel
mailing list