D25732: Add only canonical paths to dirWatcher

David Faure noreply at phabricator.kde.org
Fri Dec 6 08:11:03 GMT 2019


dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  See also commit 6be886bafae463ba <https://phabricator.kde.org/R446:6be886bafae463ba0feda93be20060814ecde9d1> in kcoreaddons (which was wrong, it would seem -- there are better ways to prevent infinite loops than to say "let's not follow symlinks at all").
  
  Doing this in kcoreaddons is also an opportunity to add a unittest for this :)
  
  What I wonder, however, is whether we also want to be notified if someone does `rm test2`, because then `test2/subdir/test` no longer exists (under that name)...

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D25732

To: hoffmannrobert, dfaure, #dolphin
Cc: kfm-devel, pberestov, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191206/8deeb852/attachment.htm>


More information about the kfm-devel mailing list