D25732: Add only canonical paths to dirWatcher

[Robert Hoffmann]

hoffmannrobert created this revision.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
hoffmannrobert requested review of this revision.

REVISION SUMMARY
  KDirWatch only works correctly with canonical paths, i.e. symbolic links resolved.

TEST PLAN
  1. Create dirs:
  
  $ mkdir test1
  $ mkdir test1/subdir
  $ ln -s test1 test2
  
  2. Start dolphin, navigate to test2/subdir, then in terminal:
  
  $ echo test > test2/subdir/test
  
  Without the patch, test2/subdir/test won't be shown automatically, only after reload (F5 <https://phabricator.kde.org/F5>).
  With the patch applied, test2/subdir/test will be shown automatically.
  
  3. Restart dolphin, navigate to test2/subdir, then in terminal:
  
  $ echo test >> test2/subdir/test
  
  Without the patch, the increased size of test2/subdir/test won't be shown automatically,
  only after reload (F5 <https://phabricator.kde.org/F5>). With the patch applied, it will be shown automatically.
  
  4. Restart dolphin, navigate to test2/subdir, then in terminal:
  
  $ rm test2/subdir/test
  
  Without the patch, test2/subdir/test stays visible, will only disappear after reload (F5 <https://phabricator.kde.org/F5>).
  With the patch applied, it will disappear automatically.

REPOSITORY
  R318 Dolphin

BRANCH
  add_only_canonical_paths_to_dirwatcher

REVISION DETAIL
  https://phabricator.kde.org/D25732

AFFECTED FILES
  src/kitemviews/private/kdirectorycontentscounter.cpp

To: hoffmannrobert
Cc: kfm-devel, pberestov, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191204/5458166d/attachment.htm>