D25335: [Details mode] Allow to fill the column size of directories with actual size

[Méven Car]

meven added a comment.


  In D25335#565799 <https://phabricator.kde.org/D25335#565799>, @ngraham wrote:
  
  > I gave this a try today. The performance is quite good and the feature works great! It will be very nice to have, even without any caching (though that is probably necessary IMO to improve the display and performance and to minimize disk wear for SSDs in particular). I have a few concerns and suggestions for improvement:
  >
  > 1. The UI to turn this on is entirely too technical. It should be more like this:
  >
  >   ``` Folder size display: (o) Number of items ( ) Size of contents [4] Levels deep ```
  
  
  I mostly followed your nice suggestion.
  
  F7796533: Screenshot_20191202_190522.png <https://phabricator.kde.org/F7796533>
  
  > I'm still not fond of exposing the maximum level of recursion in the UI, but if this is absolutely necessary, that's how it should be presented IMO.
  
  As long as we don't have a cache somewhere (and even then?), we will need to allow the user to limit the recursiveness somehow.
  We can think of alternative to the recursion level setting (I suggested a timelimit, nb of files or nb of directories scanned), but I feel most users will be comfortable with it.
  
  > 
  > 
  > 2. After turning on the feature, size values are not updated in the UI until you refresh the view or navigate elsewhere and return.
  
  Fixed
  
  > 
  > 
  > 3. When this feature is on, the number of items still appears in the size column, even though it's no longer the sort criteria: F7777384: Screenshot_20191121_112504.png <https://phabricator.kde.org/F7777384>
  
  Fixed
  I thought about keeping the item count visible when real size is displayed, but it just clutters the UI.
  
  > 
  > 
  > 4. This information needs to be available in the information panel as well.
  
  I plan to implement this in a separate diff.
  Let's keep things atomic.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D25335

To: meven, elvisangelaccio, ngraham
Cc: iasensio, kfm-devel, pberestov, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191202/77c974dd/attachment.htm>