[dolphin] [Bug 414492] Dolphin doesn't build against Qt 5.14

[David Faure]

https://bugs.kde.org/show_bug.cgi?id=414492

David Faure <faure at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |faure at kde.org

--- Comment #7 from David Faure <faure at kde.org> ---
This is..... interesting.

I'm using Qt 5.4 from git (54f5b89750, 2 weeks ago) and dolphin builds fine.
So I looked at how qevent.h gets included by views/draganddrophelper.cpp (easy
technique: put #error in qevent.h), and it turns out that the generated header
include/QtGui/QList says:
    #include <qevent.h>
!!!

I have no idea why this forwarding header even exists, there's
include/QtCore/QList which includes qlist.h as it should.

Ah, that's a bug that got fixed in Qt recently.
Commit 5771b5325b85 in qtbase says

commit 5771b5325b85f71a8f8ff78ed13eaee3df2e3ba8
Author: Andy Shaw <andy.shaw at qt.io>
Date:   Tue Nov 5 22:10:24 2019 +0100

    syncqt: Add a means to suspend/resume the processing of a file

    Rather than tweaking the parser to cover every eventuality with corner
    case lines that could cause incorrect header files to be created then
    the means to suspend/resume the processing of a file is added.

    This enables us to have it skip over the template line that is causing
    a QList header to be created as part of the QtGui headers. This patch
    includes the fix to solve this in addition.

    Fixes: QTBUG-68129
    Change-Id: I751646c4b20a4434347c149ae5e6dcb6e7618853
    Reviewed-by: Joerg Bornemann <joerg.bornemann at qt.io>

So your fixes seem correct to me.
Suddenly <QList> includes qlist.h and not qevent.h anymore...

Man, I'm not looking forward to updating my qt git and fixing compilation in
the 399 modules I build..

-- 
You are receiving this mail because:
You are on the CC list for the bug.