D25615: Refactoring to reduce size of openItemContextMenu and add the ContextType TimelineOrSearchContext

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> dolphincontextmenu.cpp:208
> +     newFileMenu->checkUpToDate();
> +     newFileMenu->setPopupFiles(QList<QUrl>() << m_fileInfo.url());
> +     newFileMenu->setEnabled(selectedItemsProps.supportsWriting());

Why this change?

> dolphincontextmenu.h:150
> +        TrashContext = 2,
> +        TimelineOrSearchContext = 4
>      };

I'd prefer to add separate `TimelineContext` and `SearchContext` values. It would be more future-proof.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D25615

To: meven, #dolphin, elvisangelaccio
Cc: kfm-devel, pberestov, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191201/ad9ba212/attachment.htm>