D23538: [dolphin] Animate gifs on preview

[Méven Car]

meven added a comment.


  In D23538#522921 <https://phabricator.kde.org/D23538#522921>, @iasensio wrote:
  
  > In D23538#522602 <https://phabricator.kde.org/D23538#522602>, @ngraham wrote:
  >
  > > Yeah, I see now that you're right.
  > >
  > > This looks great to me now. @elvisangelaccio?
  >
  >
  > Well, you were right for pointing it out, since it would have been a regression.  Thanks!
  >  I've found that the reason to refresh the pixmap even on the same item is to handle resizing the panel (D22473 <https://phabricator.kde.org/D22473>).
  
  
  Well you pointed right at a weakness in the code : resizing the widget and refreshing its content use the same code path.
  This is something I am thinking about refactoring since just like here, it is causing bugs and is not easily maintainable.
  But only after D22183 <https://phabricator.kde.org/D22183> has been merged.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D23538

To: iasensio, #dolphin, #vdg, ngraham, elvisangelaccio
Cc: pino, fuksitter, meven, broulik, kfm-devel, vmarinescu, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190831/61520028/attachment.htm>