D23538: [dolphin] Animate gifs on preview

[Ismael Asensio]

iasensio added a comment.


  Yes, I was reluctant to move this line inside the condition, but it will actually refresh the preview less, that is, no refreshing when the item to be shown is the same as the current one. In fact, this change is not needed to avoid the animation restarting, but to avoid the following flickering: F7293116: dolphin_git_flicker.gif <https://phabricator.kde.org/F7293116> F7297306: dolphin_git_flicker.gif <https://phabricator.kde.org/F7297306>.
  
  With the `refreshPreview()` call outside the condition, when `showItem()` is called twice in a row on the same item (by hovering and selecting, for example), a new thumbnail job starts, and a new static pixmap is sent to the preview. With static images, there is no issue (since it is the same image rendered).
  
  I've tested the cases with and without animation, and even media, and I found no problems, but it is possible that there is a use case for that extra refreshing outside the condition. Would it be possible to track the code changes to know why is there? Otherwise, to avoid messing a lot with the code to detect and stop that extra refresh only for the animated image case, I would go either with the current change or the restart behavior.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D23538

To: iasensio, #dolphin, #vdg, ngraham, elvisangelaccio
Cc: pino, fuksitter, meven, broulik, kfm-devel, vmarinescu, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190830/2ce110b0/attachment.htm>