D23538: [dolphin] Animate gifs on preview

Ismael Asensio noreply at phabricator.kde.org
Wed Aug 28 18:29:06 BST 2019


iasensio added a comment.


  Inline comment about supported formats

INLINE COMMENTS

> broulik wrote in informationpanelcontent.cpp:95
> Is there a way to get the mime types instead? Format doesn't neccessarily match the part after "image/", does it?
> You can also probably use a `std::transform` to turn that one list into the other one

Not necessarily, but it is usual. Currently, the supported formats are just `gif`, `mng` and `webp`, which match their mimetypes. Since there are only 3 of them, maybe we can also simply harcode them, but this would automatically adapt if a new format gets popular and it's included by Qt.
About the `std::transform`, I have tried but my C++ skills doesn't allow for a "simpler" way to do it.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D23538

To: iasensio, #dolphin, #vdg, ngraham, elvisangelaccio
Cc: broulik, kfm-devel, aprcela, vmarinescu, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190828/6bdbdf22/attachment.htm>


More information about the kfm-devel mailing list