D23412: Fix ascending/descending choosers getting unchecked when re-selecting the same sort order

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> dolphinviewactionhandler.cpp:643
>      QAction* sortByMenu =  m_actionCollection->action(QStringLiteral("sort"));
> -    foreach (QAction* groupAction, sortByMenu->menu()->actions()) {
> +    foreach (QAction* groupAction, m_sortByActions.values()) {
>          KActionMenu* actionMenu = qobject_cast<KActionMenu*>(groupAction);

No need for `values()`, and while at it port away from `foreach`

  for (QAction *groupAction : qAsConst(m_sortByActions)

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D23412

To: ngraham, elvisangelaccio, #dolphin
Cc: broulik, meven, kfm-devel, aprcela, vmarinescu, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190828/e65066a1/attachment.htm>