D23538: [dolphin] Animate gifs on preview

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> informationpanelcontent.cpp:95
> +    // mimetypes that can be animated by QMovie (gif/mng/webp)
> +    for ( const auto format : QMovie::supportedFormats() ) {
> +        m_animatedMimeTypes << QString("image/%1").arg(QString(format));

Is there a way to get the mime types instead? Format doesn't neccessarily match the part after "image/", does it?
You can also probably use a `std::transform` to turn that one list into the other one

> pixmapviewer.cpp:51
>  {
> +    delete m_movie;
>  }

Not neccessary as you parented it to `this`

> pixmapviewer.h:27
>  #include <QWidget>
> +#include <QMovie>
>  

Not neccessary to include it, you only use it as a pointer. Forward-declaration `class QMovie;` is sufficient

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D23538

To: iasensio, #dolphin, #vdg, ngraham, elvisangelaccio
Cc: broulik, kfm-devel, aprcela, vmarinescu, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190828/d9c0106d/attachment.htm>