D22183: Add click to play/pause feature on previews for audio/video

[Méven Car]

meven added a comment.


  In D22183#518560 <https://phabricator.kde.org/D22183#518560>, @alexde wrote:
  
  > > I am not against a better version, but the culprit is that I am no designer.
  > >  For anything more complicated we would need an icon/svg.
  >
  > Me neither but I created a SVG for you with Inkscape: F7278493: Play_white.svg <https://phabricator.kde.org/F7278493>
  >
  > F7278492: Play_black.svg <https://phabricator.kde.org/F7278492>
  >
  > You may use them for testing or change them the way you like.
  
  
  Those are nice, but I would rather use those in a subsequent diff not to bloat this long standing one.

INLINE COMMENTS

> elvisangelaccio wrote in informationpanelcontent.cpp:171-172
> Why remove this comment? We are still killing the preview job here, aren't we?

The comment was moved to InformationPanelContent::refreshPreview but I have re-added it here as well.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D22183

To: meven, elvisangelaccio, #dolphin, ngraham
Cc: alexde, anthonyfieroni, ngraham, kfm-devel, aprcela, vmarinescu, fprice, MrPepe, fbampaloukas, Codezela, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190826/d88db615/attachment.htm>