D23295: [Tab Bar] Resolve tab icon only if visible

Elvis Angelaccio noreply at phabricator.kde.org
Sun Aug 25 16:00:16 BST 2019


elvisangelaccio requested changes to this revision.
elvisangelaccio added a comment.
This revision now requires changes to proceed.


  Actually, it seems this breaks the build of `dolphinmainwindowtest`:
  
    ../src/tests/dolphinmainwindowtest.cpp:223:21: error: 'tabIcon' is a private member of 'DolphinTabWidget'
        if (!tabWidget->tabIcon(0).isNull() && !tabWidget->tabIcon(1).isNull()) {

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D23295

To: broulik, #dolphin, elvisangelaccio
Cc: elvisangelaccio, kfm-devel, aprcela, vmarinescu, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190825/612d4e91/attachment.htm>


More information about the kfm-devel mailing list