D22183: Add click to play/pause feature on previews for audio/video

[Elvis Angelaccio]

elvisangelaccio added a comment.


  In D22183#511449 <https://phabricator.kde.org/D22183#511449>, @elvisangelaccio wrote:
  
  > Btw I think I spotted a regression:
  >
  > 1. Start playback
  > 2. Right-click on info panel -> uncheck "Preview"
  > 3. Right-click again -> check "Preview"
  >
  >   The phonon widget does not show up again.
  
  
  Hmm, I can still reproduce this with the latest version of the patch

INLINE COMMENTS

> informationpanelcontent.cpp:171-172
>  {
>      // If there is a preview job, kill it to prevent that we have jobs for
>      // multiple items running, and thus a race condition (bug 250787).
>      if (m_previewJob) {

Why remove this comment? We are still killing the preview job here, aren't we?

> phononwidget.cpp:105
> +{
> +    Q_UNUSED(object);
> +    if (event->type() == QEvent::MouseButtonPress) {

Unnecessary semicolon

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D22183

To: meven, elvisangelaccio, #dolphin, ngraham
Cc: alexde, anthonyfieroni, ngraham, kfm-devel, aprcela, vmarinescu, fprice, MrPepe, fbampaloukas, Codezela, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190825/9d16bc3a/attachment.htm>