D23412: Fix ascending/descending choosers getting unchecked when re-selecting the same sort order

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added a comment.
This revision now requires changes to proceed.


  In D23412#518459 <https://phabricator.kde.org/D23412#518459>, @meven wrote:
  
  > A simpler alternative could be to use m_sortByActions, I have tested it.
  
  
  +1
  
  Always nice when you can fix a bug by changing a single line of code :D

INLINE COMMENTS

> dolphinviewactionhandler.cpp:636-640
>      // The radiobuttons of the "Sort By"-menu are split between the main-menu
>      // and several sub-menus. Because of this they don't have a common
>      // action-group that assures an exclusive toggle-state between the main-menu
>      // actions and the sub-menu-actions. If an action gets checked, it must
>      // be assured that all other actions get unchecked.

Also please update this comment: for example "all other actions get unchecked excluding the ascending/descending actions"

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D23412

To: ngraham, elvisangelaccio, #dolphin
Cc: meven, kfm-devel, aprcela, vmarinescu, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190825/5d1243c8/attachment.htm>