D22144: Add kio recentlyused:/ to access KActivityStats data

David Faure noreply at phabricator.kde.org
Sun Aug 25 11:23:01 BST 2019


dfaure added inline comments.

INLINE COMMENTS

> recentlyused.cpp:186
> +{
> +    qCDebug(KIO_RECENTLYUSED_LOG) << "udsEntryFromResource" << " " << resource;
> +

You don't need spaces between items, when using q[C]Debug

> meven wrote in recentlyused.h:57
> It is path currently due to limitation in RecentlyUsed::udsEntryFromResource being able to create valid UDS::Entry only for files.
> But it could evolve later to support any url that the sqlite database ~/.local/share/kactivitymanagerd/resources/database stores in its targettedResource column, including ioslave urls, kcm urls, applications desktop files...

If you want this to support non-local URLs one day then it should probably take URLs already now.

Alternatively call the argument "path" and leave "url" for later.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22144

To: meven, ivan, #frameworks, ngraham, dfaure
Cc: dhaumann, elvisangelaccio, kde-frameworks-devel, kfm-devel, aprcela, vmarinescu, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190825/a7275e14/attachment.htm>


More information about the kfm-devel mailing list