D23412: Fix ascending/descending choosers getting unchecked when re-selecting the same sort order

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: elvisangelaccio, Dolphin.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  When you select the same sort order that's already selected, the currently-checked
  sort order description (the human-readable ascending/descending items) gets unchecked
  in `slotSortTriggered()` yet the ascending/descending items items only get checked in
  `slotSortOrderChanged()`. Because the order hasn't gotten changed, neither one gets
  checked again.
  
  This patch fixes the problem by not unchecking them in the first place.
  
  BUG: 411223
  FIXED-IN: 19.08.1

TEST PLAN
  1. Right-click > Sort By > Click the currently-selected sort order
  2. Right-click > Sort By > See that the item for the current ascending/descending setting has not been changed

REPOSITORY
  R318 Dolphin

BRANCH
  fix-unchecking-sort-orders (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23412

AFFECTED FILES
  src/views/dolphinviewactionhandler.cpp

To: ngraham, elvisangelaccio, #dolphin
Cc: kfm-devel, aprcela, vmarinescu, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190824/9c040688/attachment.htm>