D23168: Use embedded cover in MP4 video files

[Elvis Angelaccio]

elvisangelaccio added a comment.


  Thanks for the patch. Please read https://community.kde.org/Policies/Commit_Policy about how to write a good commit message.

INLINE COMMENTS

> CMakeLists.txt:6-21
> +include(FindPkgConfig)
> +
> +if(NOT PKG_CONFIG_FOUND)
> +  message(FATAL_ERROR "pkg-config not found!" )
> +endif()
> +
>  find_package(ECM 1.0.0 REQUIRED NO_MODULE)

Please add a `cmake/FindTaglib.cmake` file (you can re-use https://cgit.kde.org/kio-extras.git/tree/cmake/FindTaglib.cmake) and then use `find_package(Taglib)` instead of requiring `pkg-config`.

> filmstripfilter.h:29
>      virtual ~FilmStripFilter() {}
> -    virtual void process(VideoFrame& videoFrame);
> +    virtual void process(VideoFrame& videoFrame) override;
>  };

Is this change related?

> moviedecoder.cpp:253-254
>  
> -    int frameFinished = 0;
> -
>      avcodec_send_packet(m_pVideoCodecContext, m_pPacket);

Is this change related? If not, we should do it in another commit.

REPOSITORY
  R343 FFmpeg Thumbnailers

REVISION DETAIL
  https://phabricator.kde.org/D23168

To: hschaefer, bruns, #dolphin, elvisangelaccio, broulik
Cc: ngraham, meven, cfeck, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190824/ed8800b0/attachment.htm>