D22802: [dolphin] make link with LLVM
Elvis Angelaccio
noreply at phabricator.kde.org
Sat Aug 24 11:13:47 BST 2019
elvisangelaccio added a comment.
In D22802#512261 <https://phabricator.kde.org/D22802#512261>, @rjvbb wrote:
> > Untested: have you tried to make `dolphinprivate` a `PUBLIC` dependency of `kdeinit_dolphin`?
>
> Appears that this works too:
>
> target_link_libraries(kdeinit_dolphin PUBLIC
> dolphinprivate
> PRIVATE
> dolphinstatic
> KF5::Crash
> )
>
Cool. I'd prefer this fix, so that we don't add another `target_link_libraries` call.
REPOSITORY
R318 Dolphin
REVISION DETAIL
https://phabricator.kde.org/D22802
To: rjvbb, elvisangelaccio
Cc: kfm-devel, #kde_applications, aprcela, vmarinescu, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190824/2519bbee/attachment.htm>
More information about the kfm-devel
mailing list