D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes
Simon Redman
noreply at phabricator.kde.org
Mon Aug 19 04:08:16 BST 2019
sredman added a comment.
In D22727#513842 <https://phabricator.kde.org/D22727#513842>, @dfaure wrote:
> The truth is stronger than "I would not recommend".
> put() in SlaveBase-derived classes is called by the KIO library (TransferJob), so you CANNOT change the meaning of the arguments. It's part of the API/ABI for all slaves, and this cannot change until KF6.
+1
But it is worth making a note of this as something to change (or discuss changing) for KF6 since it seems like using the Qt constants would be a better design
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D22727
To: brute4s99, vonreth, dfaure, pino
Cc: sredman, pino, kde-frameworks-devel, kfm-devel, aprcela, vmarinescu, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190819/b80c0db4/attachment.htm>
More information about the kfm-devel
mailing list