D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes

[Simon Redman]

sredman added a comment.


  In D22727#510698 <https://phabricator.kde.org/D22727#510698>, @brute4s99 wrote:
  
  > In D22727#505540 <https://phabricator.kde.org/D22727#505540>, @dfaure wrote:
  >
  > > But, wait, this code is mixing "int permissions" (*) with the QFileDevice enum, that doesn't make any sense to me.
  > >
  > > (*) this comes from KIO::put, which takes unix permissions on unix, not sure what it takes on Windows...
  > >
  > > This doesn't match: unix permissions are octal (e.g. group read is 040 in octal), QFileDevice enum is hex (0x040).
  >
  >
  > Okay. I'm still unable to understand where/ how sftp::put() is called, or I would change everywhere it is called, to Qt way of permission extraction.
  
  
  I would recommend not making API or ABI changes. It's annoying that they're not compatible, but you can probably find some way to convert from Qt permissions to the expected values in order to not change users

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22727

To: brute4s99, vonreth, dfaure, pino
Cc: sredman, pino, kde-frameworks-devel, kfm-devel, aprcela, vmarinescu, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190818/4bcd8b28/attachment.htm>