D23232: [dolphin] Make search action toggle the searchbar

[Ismael Asensio]

iasensio updated this revision to Diff 63960.
iasensio added a comment.


  - Add an independent toggle_search action
  
  After a while, I came to the conclussion that providing two different actions is the only sane way to do it.
  QActions are meant to achive the same behavior independent of the source (keyboard, button, menu, ...) so it encapsulates the source very deeply. In this case we want two different behaviors, which leads us to two different actions.
  
  In the screenshow I keep both toolbuttons for comparison, and to "simulate" visually the effect of Ctrl-F, but ideally every user would keep only one of them. 
  This way, the request on bug 344617 (and my own :)) gets satisfied, and the Ctrl-F behavior works as before.
  
  I've also tested the behavior against split view and tabs (which was the main concern of T8473 <https://phabricator.kde.org/T8473>), and it seems consistent, as the ActiveViewChanged signal updates the button status.

REPOSITORY
  R318 Dolphin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23232?vs=63957&id=63960

BRANCH
  toggle_search_independent

REVISION DETAIL
  https://phabricator.kde.org/D23232

AFFECTED FILES
  src/dolphinmainwindow.cpp
  src/dolphinmainwindow.h
  src/dolphinviewcontainer.cpp
  src/dolphinviewcontainer.h

To: iasensio, #dolphin, ngraham
Cc: elvisangelaccio, kfm-devel, aprcela, vmarinescu, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190818/e7a03cb0/attachment.htm>