D23232: [dolphin] Make search action toggle the searchbar

[Ismael Asensio]

iasensio created this revision.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
iasensio requested review of this revision.

REVISION SUMMARY
  Make search action toggle the searchbar instead of just launching it.
  
  The search action in dolphin did only bring up the search bar, but to close it again you had to go to the closing button on the same searchbar. 
  This behavior in inconsistent with other dolphin actions which toggle panels or tools.

TEST PLAN
  - Enable the search mode: the searchbar appears and the toolbar button gets checked
  - Press the search button again, and it goes back to normal mode.
  - The search button state is coherent with the searchbox showing or not.
  - Different input methods (toolbar button, menu, keyboard) work as expected

REPOSITORY
  R318 Dolphin

BRANCH
  toggle_search

REVISION DETAIL
  https://phabricator.kde.org/D23232

AFFECTED FILES
  src/dolphinmainwindow.cpp
  src/dolphinmainwindow.h
  src/dolphinviewcontainer.cpp
  src/dolphinviewcontainer.h

To: iasensio
Cc: kfm-devel, aprcela, vmarinescu, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190817/383e0f39/attachment.htm>