D17595: Upstream Dolphin's file rename dialog

Stefan BrĂ¼ns noreply at phabricator.kde.org
Sat Aug 17 04:22:48 BST 2019


bruns added inline comments.

INLINE COMMENTS

> dfaure wrote in renamefiledialog.cpp:119
> Oops yes I meant items.first().url().path(). OK for fileName(), path() is faster but this code path isn't speed critical.

anything wrong with `KFileItem::name()`?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17595

To: meven, #frameworks, #dolphin, broulik, ngraham, dfaure
Cc: dfaure, sitter, mitchell, emmanuelp, ltoscano, bruns, meven, dhaumann, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190817/905e02db/attachment.htm>


More information about the kfm-devel mailing list