D23168: Use embedded cover in MP4 video files

[Heiko Schaefer]

hschaefer added inline comments.

INLINE COMMENTS

> ffmpegthumbnailer.cpp:51
> +    TagLib::MP4::File f(path.toStdString().c_str(), false);
> +
> +    if(f.isValid()) {

A quick glance at the source code of taglib revealed that in `isValid()` are 2 checks are done

1. check if there are atoms at alll
2. check if there is a "moov" atom

I have directories with more than 50 MP4s all including covers and it is reasonable fast. Defintely faster than extracting the same amount of still frames out of the video.

REPOSITORY
  R343 FFmpeg Thumbnailers

REVISION DETAIL
  https://phabricator.kde.org/D23168

To: hschaefer, bruns, #dolphin, elvisangelaccio, broulik
Cc: meven, cfeck, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190815/0013c5fe/attachment.htm>