D23168: Use embedded cover in MP4 video files

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> ffmpegthumbnailer.cpp:50
>  {
> +    TagLib::MP4::File f(path.toStdString().c_str(), false);
> +

I hope this kind of check is not too heavy, or we might to check the file mimetype before.

> ffmpegthumbnailer.cpp:52
> +
> +    if(f.isValid()) {
> +

Missing space after if

> ffmpegthumbnailer.cpp:59
> +
> +        if(!coverArtList.isEmpty()) {
> +            TagLib::MP4::CoverArt coverArt = coverArtList.front();

Same

> ffmpegthumbnailer.cpp:64
> +
> +            if(!img.isNull()) return true;
> +        }

Same

REPOSITORY
  R343 FFmpeg Thumbnailers

REVISION DETAIL
  https://phabricator.kde.org/D23168

To: hschaefer, bruns, #dolphin, elvisangelaccio, broulik
Cc: meven, cfeck, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190815/8f19bdd7/attachment.htm>