D23159: Prevent error() being emitted when purposefully reading 0 bytes

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> file.cpp:520
> +        // Nothing to do...
> +        return data(QByteArray());
> +    }

this should be

  {
      Q_EMIT data({});`
      return;
  }

I'm not sure that we'd need an empty data emitted then. Are you trying to fix a specific bug that triggers this?

> file.cpp:526
>  
>          if (!res.isEmpty()) {
>              data(res);

alternatively this could also check ` && bytes != 0`

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23159

To: feverfew, dfaure, fvogt, chinmoyr
Cc: apol, kfm-devel, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190814/556bbfa2/attachment.htm>