D22183: Add click to play/pause feature on previews for audio/video

[Elvis Angelaccio]

elvisangelaccio added a comment.


  Btw I think I spotted a regression:
  
  1. Start playback
  2. Right-click on info panel -> uncheck "Preview"
  3. Right-click again -> check "Preview"
  
  The phonon widget does not show up again.

INLINE COMMENTS

> meven wrote in phononwidget.cpp:103-119
> I did.
> I needed to have an eventFilter so that I can reuse this code directly, informationpanelcontent.cpp line 244 :
> 
>   m_preview->installEventFilter(m_phononWidget);

Why would we need that? I just tried to move this code from `eventFilter()` to `mousePressEvent()` and it seems to work fine.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D22183

To: meven, elvisangelaccio, #dolphin, ngraham
Cc: anthonyfieroni, ngraham, kfm-devel, aprcela, vmarinescu, fprice, MrPepe, fbampaloukas, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190813/16b23bec/attachment.htm>