D22420: Fix an issue with focus lost after closing terminal panel

[Elvis Angelaccio]

elvisangelaccio accepted this revision.
elvisangelaccio added a comment.
This revision is now accepted and ready to land.


  In D22420#503573 <https://phabricator.kde.org/D22420#503573>, @AndreyYashkin wrote:
  
  > In D22420#503317 <https://phabricator.kde.org/D22420#503317>, @elvisangelaccio wrote:
  >
  > > I'd still like to understand what happend at the change in 4e40fe810d324 <https://phabricator.kde.org/R318:4e40fe810d324e69eeb824e40011e509e6676aaf>.
  > >
  > > @ngraham Any idea?
  >
  >
  > @elvisangelaccio, I read the description of change in 4e40fe810d324 <https://phabricator.kde.org/R318:4e40fe810d324e69eeb824e40011e509e6676aaf> and bug 298467, which was fixed in it more carefull and understood that the change was supposed to introduce the feature of setting the focus back to the active view. However, it seems that Ctrl-D or exit command cases were not tested good enough.
  
  
  Right. The fix looks correct to me, going to push it to master (with an improved commit message).

INLINE COMMENTS

> AndreyYashkin wrote in dolphinmainwindow.cpp:754
> //m_activeViewContainer// is //NULL// when Dolphin starts and without this change app crashes.

You're right, it was a problem also before and it was working just by luck...

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D22420

To: AndreyYashkin, #dolphin, elvisangelaccio
Cc: ngraham, elvisangelaccio, kfm-devel, aprcela, vmarinescu, fprice, fbampaloukas, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190811/c21291e2/attachment.htm>