D23087: Do not match daemonized dolphin instances: part 2

[Alexander Saoutkin]

feverfew accepted this revision.
feverfew added a comment.
This revision is now accepted and ready to land.


  Can't test, but looks sane to me. I have a small comment, but can be left for later if time is of the essence.

INLINE COMMENTS

> global.cpp:107-110
>              if (!instance->isValid() || instance->lastError().isValid()) {
>                  continue;
>              }
>              dolphinServices.append(qMakePair(instance, QStringList()));

I think now it would be appropriate to change this to read the same as L93-95.

REPOSITORY
  R318 Dolphin

BRANCH
  Applications/19.08

REVISION DETAIL
  https://phabricator.kde.org/D23087

To: elvisangelaccio, ngraham, feverfew
Cc: cfeck, kfm-devel, aprcela, vmarinescu, fprice, fbampaloukas, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190811/a91febe7/attachment.htm>