D20532: Proof of Concept: Add double click actions to empty space in the folder view

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> kitemlistcontroller.cpp:817
> +    }
> +    DolphinView *view = qobject_cast<DolphinView*>(parent()->parent());
> +    DolphinMainWindow *mainWindow = (DolphinMainWindow *)QApplication::activeWindow();

Check against nullptr parent() as well

> kitemlistcontroller.cpp:818
> +    DolphinView *view = qobject_cast<DolphinView*>(parent()->parent());
> +    DolphinMainWindow *mainWindow = (DolphinMainWindow *)QApplication::activeWindow();
> +    if (mainWindow == nullptr || view == nullptr || clickAction == "none") {

Don't use C-style cast.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D20532

To: fbg13, #dolphin, elvisangelaccio, #vdg, ngraham
Cc: anthonyfieroni, kneckermcknacksack, ngraham, kfm-devel, aprcela, vmarinescu, fprice, fbampaloukas, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190808/95585c59/attachment.htm>