D23006: [webenginepart] Fix build with cmake < 3.7
Wolfgang Bauer
noreply at phabricator.kde.org
Wed Aug 7 17:35:56 BST 2019
wbauer created this revision.
wbauer added a reviewer: Konqueror.
wbauer added a project: Konqueror.
wbauer requested review of this revision.
REVISION SUMMARY
`VERSION_GREATER_EQUAL` was introduced in cmake 3.7, but the specified minimum version is 3.0.
So use `NOT VERSION_LESS` instead to still support older cmake versions too.
TEST PLAN
Builds fine with cmake 3.5.2 now, and also newer versions.
The corresponding definitions are still passed to gcc when building with QtWebEngine 5.13 (haven't tried older versions), according to the build output.
Before, I got this error when using cmake 3.5.2:
CMake Error at webenginepart/src/CMakeLists.txt:30 (if):
if given arguments:
"Qt5WebEngineWidgets_VERSION" "VERSION_GREATER_EQUAL" "5.12.0"
Unknown arguments specified
REPOSITORY
R226 Konqueror
REVISION DETAIL
https://phabricator.kde.org/D23006
AFFECTED FILES
webenginepart/src/CMakeLists.txt
To: wbauer, #konqueror
Cc: #konqueror, rrosch, domson, demsking
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190807/af5bdc1c/attachment.htm>
More information about the kfm-devel
mailing list