D22984: Fix build with cmake < 3.7

Wolfgang Bauer noreply at phabricator.kde.org
Wed Aug 7 10:45:01 BST 2019


wbauer created this revision.
wbauer added a reviewer: Dolphin.
wbauer added a project: Dolphin.
Herald added a subscriber: kfm-devel.
wbauer requested review of this revision.

REVISION SUMMARY
  `VERSION_GREATER_EQUAL` was introduced in cmake 3.7, but the specified minimum version is 3.0.
  So use `VERSION_LESS` instead (and swap the branches) to still support older cmake versions too.

TEST PLAN
  Builds fine with cmake 3.5.2 now, and also newer versions.
  The file is still installed to ${KDE_INSTALL_LOGGINGCATEGORIESDIR} when building with latest KF5 from git, haven't tried older versions.
  
  Before, I got this error when using cmake 3.5.2:
  
    CMake Error at CMakeLists.txt:153 (if):
      if given arguments:
    
        "ECM_VERSION" "VERSION_GREATER_EQUAL" "5.59.0"
    
      Unknown arguments specified

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D22984

AFFECTED FILES
  CMakeLists.txt

To: wbauer, #dolphin
Cc: kfm-devel, #dolphin, aprcela, vmarinescu, fprice, fbampaloukas, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190807/6f86f42c/attachment.htm>


More information about the kfm-devel mailing list