D20856: [TagsFileItemAction] Move expensive tag retrieval out of the loop

Elvis Angelaccio noreply at phabricator.kde.org
Sun Apr 28 11:27:17 BST 2019


elvisangelaccio added inline comments.

INLINE COMMENTS

> tagsfileitemaction.cpp:48
>  
> +        QStringList fileTags = m_metaData->tags();
> +

Missing `const`

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D20856

To: bruns, #baloo, #dolphin, nicolasfella, ngraham, elvisangelaccio
Cc: meven, gennad, domson, ashaposhnikov, astippich, spoorun, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190428/64375a18/attachment.htm>


More information about the kfm-devel mailing list